search

DiODeProject / MuMoT

Multiscale Modelling Tool - mathematical modelling without the maths
https://mumot.readthedocs.io/
GNU General Public License v3.0
21 stars 5 forks source link

I think MuMoTnoiseCorrelationsView.noiseODEsys(yin, t) is wrongly defined... #287

Closed joefresna closed 5 years ago

joefresna commented 5 years ago

https://github.com/DiODeProject/MuMoT/blob/72887ad3cc6d22d53c82ce032dc5a864cd7d2c29/mumot/__init__.py#L4196

@tbose1, could you confirm? I will then (attempt) to correct it.

joefresna commented 5 years ago

This line was correct, but few lines above there was a bug due to changing dictionary keys within a loop of that dictionary... The bug was visible sometimes only when there were more than two constant reactant and when some random (python-compiler-selected) sorting was taking place... Hard to spot but fixed in the next commit of #286

joefresna commented 5 years ago

Annoyingly, also this issue was there for a while but tests couldn't spot it until yesterday (my lucky day :-) )

jarmarshall commented 5 years ago

Good to close I think @joefresna