search

DiODeProject / MuMoT

Multiscale Modelling Tool - mathematical modelling without the maths
https://mumot.readthedocs.io/
GNU General Public License v3.0
21 stars 5 forks source link

Duplicate code in MuMoTview._get_bookmarks_params() and MuMoTview._get_params() calls for bugs #290

Closed joefresna closed 5 years ago

joefresna commented 5 years ago

These methods do more or less the same thing, but instead to reuse code there is a messy copy-paste... The original idea was that _get_bookmarks_params() would call _get_params()

jarmarshall commented 5 years ago

I think you can close this now @joefresna - if you use Fixes #<num1> Fixes #<num2> in the commit message it will happen automatically (check the exact syntax for multiple issues though)

joefresna commented 5 years ago

I will close all issue when #286 gets accepted

jarmarshall commented 5 years ago

Good to close I think @joefresna