search

DiODeProject / MuMoT

Multiscale Modelling Tool - mathematical modelling without the maths
https://mumot.readthedocs.io/
GNU General Public License v3.0
21 stars 4 forks source link

Unpin sympy version (WIP) #344

Closed willfurnass closed 5 years ago

willfurnass commented 5 years ago

Attempts to address #170. Replaces an abandoned PR (#343).

jarmarshall commented 5 years ago

I believe I have fixed this now, for Sympy 1.4... Unfortunately the update to Sympy does not seem to have solved issue #322 Some of the longer equations do not now render (they appear briefly, only to be replace by a [Math Processing Error] message, although before rendering the equation seems properly structured (and grabbing it and typesetting it elsewhere works), and shorter equations still render correctly. This is on Mac - @willfurnass can you check on Linux? Will need to add an issue on MuMoT or elsewhere to get this resolved...

jarmarshall commented 5 years ago

OK - the same error crops up elsewhere - trying again... should really install tox...

codecov-io commented 5 years ago

Codecov Report

Merging #344 into master will increase coverage by 0.32%. The diff coverage is 93.54%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #344      +/-   ##
==========================================
+ Coverage   68.85%   69.18%   +0.32%     
==========================================
  Files           9        9              
  Lines        5748     5984     +236     
  Branches     1572     1718     +146     
==========================================
+ Hits         3958     4140     +182     
- Misses       1396     1441      +45     
- Partials      394      403       +9
Impacted Files Coverage Δ
mumot/views.py 66.73% <100%> (+0.6%) :arrow_up:
mumot/models.py 71.96% <87.5%> (+0.13%) :arrow_up:
mumot/controllers.py 78.2% <0%> (+0.19%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8810f1c...3b9cb72. Read the comment docs.

jarmarshall commented 5 years ago

@willfurnass this looks good to me now - please check the Sympy package requirement change I made (1.3 -> 1.4) won't cause you other problems, and merge... need to look into that MathJax rendering error though...

jarmarshall commented 5 years ago

Upgraded to Python 3.7.4 and I no longer see the MathJax rendering error so closing and merging this now