search

DiODeProject / MuMoT

Multiscale Modelling Tool - mathematical modelling without the maths
https://mumot.readthedocs.io/
GNU General Public License v3.0
21 stars 4 forks source link

Replace latex2sympy's process_sympy with sympy's parse_latex #348

Closed willfurnass closed 4 years ago

willfurnass commented 5 years ago

Will hopefully address #300

codecov-io commented 5 years ago

Codecov Report

Merging #348 into master will increase coverage by 0.07%. The diff coverage is 80.64%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #348      +/-   ##
==========================================
+ Coverage   68.88%   68.95%   +0.07%     
==========================================
  Files           9        9              
  Lines        5765     5766       +1     
  Branches     1572     1572              
==========================================
+ Hits         3971     3976       +5     
+ Misses       1399     1397       -2     
+ Partials      395      393       -2
Impacted Files Coverage Δ
mumot/consts.py 100% <100%> (ø) :arrow_up:
mumot/__init__.py 84.61% <100%> (ø) :arrow_up:
mumot/utils.py 67.7% <100%> (ø) :arrow_up:
mumot/views.py 66.2% <71.42%> (ø) :arrow_up:
mumot/models.py 71.98% <77.77%> (+0.02%) :arrow_up:
mumot/controllers.py 78.2% <0%> (+0.76%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1679c57...ef088fd. Read the comment docs.

jarmarshall commented 4 years ago

I've reviewed the changes, the tests are all passed, this seems good to me. Good to unpin antlr4-python3-runtime (see issue https://github.com/sympy/sympy/issues/17629)... you flagged this as work in progress @willfurnass - any reason not to merge?

willfurnass commented 4 years ago

I've renamed and merged the PR.