search

DiSSCo / ELViS

European Loans and Visits System
https://elvis.dissco.eu/
6 stars 2 forks source link

TA: Show only requests for my institution doesn't work #188

Closed mmarschler closed 3 years ago

mmarschler commented 3 years ago

Description

When I'm logged in as a TA coordinator and go to requests, I see all requests including the ones for my institution. When I filter them by clicking "Show only requests for my institution" I don't see a single request.

Steps to reproduce the issue

  1. Log in as TA coordinator or institutional moderator
  2. Go to tab "requests"
  3. Filter "Show only requests for my institution"

What's the expected result?

What's the actual result?

Additional details / screenshot

ELViS_all_requests_2021-02-08 ELViS_requests_my_inst_2021-02-08

cannedit commented 3 years ago

This is probably due to a mixture of roles; we will look into this.

cannedit commented 3 years ago

We're still working on the handling of TA requests, so this will be fixed during the next sprint.

cannedit commented 3 years ago

This has been taken care of, please test.

mmarschler commented 3 years ago

it works fine now.

falkogloeckler commented 3 years ago

Did someone test it with the "TA coordinator" role or with the "institutional moderator" role only? According to feedback I got, the filter "Show only requests for my institution" is not displayed for our TA coordinator (MfN). She is also a institutional moderator. If the issue is due to a mixture of roles, does this have to be solved per account? Thanks for any advice!

mmarschler commented 3 years ago

It tested it with our general account, which has all roles (TA coord., VA coord. and inst. mod.).