DiSSCo / ELViS

European Loans and Visits System
https://elvis.dissco.eu/
6 stars 2 forks source link

Text below submitted request to be updated #196

Closed LarissaS closed 3 years ago

LarissaS commented 3 years ago

Description

requester can still open submitted request with 'to be evaluated" status and update an information. The in text below it's written "VA coordinator" instead of "TA coordinator" (see screenshot)

Steps to reproduce the issue

  1. Open in My request 'to be evaluated" request
  2. go to the end of the proposal
  3. Under "Is your request ready to be updated?" you will see the text for VA call

What's the expected result?

TA coordinator as we are in TA request

What's the actual result?

- image

Additional details / screenshot

LarissaS commented 3 years ago

It is updated, but change "digitising institutes" to "host institutes".

cannedit commented 3 years ago

See Github issue #190

LarissaS commented 3 years ago

"Digitizing institute" is not updated, it has to be 'host institutes"

In general I find it not clear for a requester:

image

after he submitted the application he still can edit it and at the end he sees the text "Is your request ready to be updated? If you have corrected and/or completed your request according to the instructions of the TA coordinators as provided via their comments, you can submit your changed request for approval again via the “Update request”-button. This is NOT yet the final submission. The final Submission will be dealt with via scoring after all TA coordinators from the digitising institutes involved have approved your request." image

I think it has to be clear BEFORE first submission that this is not yet final submission, but submission for approval by TA coordinator ! So, may be we could put a similar text, something like ""Is your request ready to be submitted? This is NOT yet the final submission. Your request has to be approved by TA coordinator. You still can update your request according to his/her comments. The final Submission will be dealt with via scoring after all TA coordinators from the digitising institutes involved have approved your request." The last phrase is also odd! It's not a submission which will be dealt via scoring. Shell I write Krissie to look into it?

cannedit commented 3 years ago

@LarissaS we will take care of changing the "Digitizing institutes" into "Host institutes" as part of the minor issues still to be taken care of; as for any further text changes, if really necessary we need to receive them asap, but actually we don't have time anymore to discuss text changes back and forth, and we already did a thorough overhaul of all texts based on input from Krissie and Scott a few weeks ago.

LarissaS commented 3 years ago

Fine for me!

cannedit commented 3 years ago

We have changed the text now, see the screenshot attached, please test again. ELViS_Acceptance_NewUpdateRequestText