DiSSCo / ELViS

European Loans and Visits System
https://elvis.dissco.eu/
6 stars 2 forks source link

mistakes in the email that new Ta request is created #199

Closed LarissaS closed 3 years ago

LarissaS commented 3 years ago

Description

As a TA coordinator I've got a confirmation mail that new request is created. In the text "VA" should be changed to "TA"; link (url) is not working Check also dots at the end of a sentences.

Strange that for requests which I created under my institutional mail I did not get any notifications as a TA coordinator!

Steps to reproduce the issue

What's the expected result?

What's the actual result?

image

Additional details / screenshot

jgrieb commented 3 years ago

I also experienced problems with the emails. I use two accounts, one with requester role & one with TA coordinator+requester role. When I submitted 2 TA requests via the requester account, I did not receive any Email at all as TA coordinator. When I submitted a TA request with the TA coordinator account itself, I received an Email. It had the same problem as above (text needs to be changed).

Also, the URL provided in the Email does not work, it would need to be changed to {frontendUrl/requests/ta/{id}

mmarschler commented 3 years ago

same here!

cannedit commented 3 years ago

This is solved now, please test.

LarissaS commented 3 years ago

Text ok, url prorvided does not work properly: image

cannedit commented 3 years ago

I noticed there is a subdirectory missing in the url in the email notification: "requests" should be: "requests/ta" (and the same for VA requests: "requests" should be: "requests/va"). We will fix this.