DiSSCo / ELViS

European Loans and Visits System
https://elvis.dissco.eu/
6 stars 2 forks source link

Cannot add number of days to equipment #227

Open scottwilson-nhm opened 3 years ago

scottwilson-nhm commented 3 years ago

I have made a joint GB-TAF Request, requesting access to NHM and Royal Botanic Gardens Edinburgh - 10 working days in total.

However when I select equipment to use, I cannot enter a value other than '0'

image

This is an important part of the rationale that scorers and hosts assess to see if a visit length is appropriate.

cannedit commented 3 years ago

We have discovered that this is occasionally happening, for example in case the start and end date for the visit are not given; the amount of days that a facility can be 'reserved' is depending on the calculation of the proposed length of visit, which in turn depents on the start and end date. We will try to solve this by providing a 2 week range for the usage of the facilities in case this happens, but ofc it would be best to check whether the start and end dates are provided first.

scottwilson-nhm commented 3 years ago

Hi Wim,

I've put through a few Requests now where the day calculation and booking equipment has been fine. Setting a two week range for the usage of facilities is not the fix for this problem - 2 weeks is the average length of stay for funded visits but we have had visits that last a lot longer. Please don't set any hard limits on how long equipment (inc. collections) can be used for.

All best,

Scott

Scott Wilson Grants Administrator | SYNTHESYS+ Administrator Research Coordination Office The Natural History Museum @.**@.> www.nhm.ac.ukhttp://www.nhm.ac.uk/

From: Wim van Dongen @.> Sent: 11 March 2021 13:30 To: DiSSCo/ELViS @.> Cc: Scott Wilson @.>; Author @.> Subject: Re: [DiSSCo/ELViS] Cannot add number of days to equipment (#227)

We have discovered that this is occasionally happening, for example in case the start and end date for the visit are not given; the amount of days that a facility can be 'reserved' is depending on the calculation of the proposed length of visit, which in turn depends on the start and end date. We will try to solve this by providing a 2 week range for the usage of the facilities in case this happens, but ofc it would be best to check whether the start and end dates are provided first.

- You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FDiSSCo%2FELViS%2Fissues%2F227%23issuecomment-796735973&data=04%7C01%7Cscott.wilson%40nhm.ac.uk%7Cd37a0d12be864cc48fc608d8e491ca53%7C73a29c014e78437fa0d4c8553e1960c1%7C1%7C0%7C637510662127422589%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=I9Q3WGduSIHxF7EXwbrNRhgMq3MjcEYNxo5FH8TIwh8%3D&reserved=0, or unsubscribehttps://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAOBBIFBJ5HWIVALO243I6F3TDDAV7ANCNFSM4ZADFI4Q&data=04%7C01%7Cscott.wilson%40nhm.ac.uk%7Cd37a0d12be864cc48fc608d8e491ca53%7C73a29c014e78437fa0d4c8553e1960c1%7C1%7C0%7C637510662127432548%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=RwRWZmJ7ae9dAv2rv3HNiVu7bhaRuucHUqTgtFPp7wc%3D&reserved=0.

cannedit commented 3 years ago

@scottwilson-nhm I think you misunderstood me: the amount of 15 days is only set for facilities in case a requester forgot to provide a start and end date, so there is no proposed length of visit on which the amount of days to be reserved for facilities can be given. In case that 15 days limit kicks in, then a requester can go back to the start and end dates and provide the proper information, so that the real amount of days will be shown for the facilities. Please take a look at the video attached (sorry, had to shorten that a bit because of the 10 Mb limit here on Github)

https://user-images.githubusercontent.com/22167327/110936540-55bcba00-8331-11eb-8cf8-81cc297f2523.mp4