Closed cannedit closed 2 years ago
Pdf download works fine, but the fields are still not shown correctly (see enclosed pdf). I filled in the maximum amount of signs in the fields "Workplan", "Justification of the request" and "specify which collection", but you can only see only one line. Additionally, in the section "Institution services" the name of the facilities are not shown but only "test 1".
An issue of userfriendlyness: It would be nice if the pdf was named with the name of the requester, not only a long number of figures and signs.
@mmarschler:
You tested the PDF of the TA Call request using long strings of characters without spaces, hence the whole text doesn’t show properly. In case it was tested with ‘real’ sentences, so with spaces between words, the result would be different (see the PDF attached of a TA Call request I produced).
Regarding the facilities in the PDF you attached here: I can't recognise those as being facilities of the institution currently in the ELViS Acceptance server, so I suggest you test this again, maybe for another institution, then we can checke whether this can be reproduced (see also the facilities in the PDF I attached here) and hence have to be bugfixed?
As for the naming of the PDF/zip file: currently it contains the UUID of the Request, so in that way it's now linked directly to this specific request. Such uniqueness can't be obtained in case we use the name of the requester as naming convention.
1_request_c33424a6-37d5-4076-a5fd-183347721b6b.pdf
@cannedit Thanks for your comments, Wim.
Regarding the facilities-names in the pdf: I've made a pdf of a request from Larissa for RMCA, and there the name of the facilities are correctly shown: 1_request_dd9b2c10-3199-41dd-ad4c-601fb648a77e_RMCA.pdf
As a institution moderator, I added 2 new facilities to our institution. Then, as a requester, I made a new request. Still the names of our facilities are not correctly shown in the pdf (in ELViS itself, the names are shown correctly): 1_request_c3210047-05ed-4e34-9f9f-4fa5e035a696_NHMW.pdf
Please test this again and in particular the mentioning of the requested resources, because there seems to be a problem with this at least for the institution Royal Museum for Central Africa/Belgium.
I have just sent a TA request to the Royal Museum for Central Africa/Belgium. I guess Larissa will get it.
I created pdfs with my synthesys@nhm-wien.ac.at -profile. Everything is fine with Meise and RMCA-pdfs, but in Vienna-pdfs the facilities are still not shown correctly.
Meise_1_request_025a571d-c7dc-4904-b18a-fa9555b78d49.pdf
As a requester I asked in resources needed 7 days at Jemu research infrastructure (see "dna extraction project" request for RMCA). In pdf I do not see Jemu research infrastructure at all, instead there are 7 days for test 2 facility, see here: RMCA_request.pdf
I have just sent a TA request to the Royal Museum for Central Africa/Belgium. I guess Larissa will get it.
I do not see any request of Begona! What is the title?
TA test made by BEGOÑA SANCHEZ
I found it! It was at the end of my list because the date of your request is 18/02/2021!
Checking TA test made by BEGOÑA SANCHEZ: number of days in pdf is the same, but names of facilities are not corresponding! For example in her request there is no Wood lab, in pdf well! see pdf here: 1_request_066373be-6724-4767-9f03-900b27d6b7e0.pdf
@mmarschler @LarissaS @B-San-Chi: Ok we're going to look into this (PDF not showing correct facilities as requested) once more.
Sorry!!!
It was another request recycled!!!
De: Smirnova Larissa @. Enviado el: viernes, 18 de marzo de 2022 13:54 Para: DiSSCo/ELViS @.> CC: Begoña Sánchez Chillón @.>; Comment @.> Asunto: Re: [DiSSCo/ELViS] Incorporate Resource Needs per Institition in the TA Call PDF (Issue #235)
I found it! It was at the end of my list because the date of your request is 18/02/2021!
https://user-images.githubusercontent.com/949726/159006288-f6cbe7cd-fa4f-4179-89fd-58b18cfd6ade.png
— Reply to this email directly, view it on GitHub https://github.com/DiSSCo/ELViS/issues/235#issuecomment-1072382232 , or unsubscribe https://github.com/notifications/unsubscribe-auth/AOBABG4Z5T2MTPOSGC36VADVAR4E5ANCNFSM5NOUTVIQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub . You are receiving this because you commented. https://github.com/notifications/beacon/AOBABG7QQIKZJFO65JEZVCLVAR4E5A5CNFSM5NOUTVI2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOH7VUCGA.gif Message ID: @. @.> >
Description
NHM Evaluation Excel sheet no. 6: PDF download function to be improved / PDF export function currently (June 2021) does not correctly show the Resource Needs section
Agreement
We will improve the TA Call Request PDF by incorporating Resource Needs.