DiSSCo / ELViS

European Loans and Visits System
https://elvis.dissco.eu/
6 stars 2 forks source link

TA Call Request Scoring functionality #238

Closed cannedit closed 2 years ago

cannedit commented 2 years ago

The Scoring functionality for approved TA Call Requests has been implemented (see the manual page 51-54).

This can be handled by a person holding the TA Scorer role (per country) and the general admin

LarissaS commented 2 years ago

as a regular user I created a request for RMCA (title "My 2nd request") and submitted it. Logged in as TA coordinator Arnaud Henrard I do not see it in requests assigned to me. I have the impression that I don't see any requests from a new 2022 call.

cannedit commented 2 years ago

I guess this comment is actually referring to Github issue #236, but I can react on it over here anyway: it's still the idea that there can only be one TA Coordinator per institution and at the moment both Arnaud Henrard and you hold that role, so please correct this and check again? ELViS_TA_Coordinator_RMC

wolodkin commented 2 years ago

In contrast, the testers without Admin or TAF Admin rights are asked to test whether they, as requesters, can see the name, e-mail, gender & ORCID ID of all ELViS-registered users.

There is no information about the gender.

cannedit commented 2 years ago

@wolodkin: I guess your comment is a result of testing Github issue #231 ?

mmarschler commented 2 years ago

The scoring functionality seems to work properly. I tested it with several different accounts, and I can see and score only requests for which I have the role TA scorer.

Concerning the status "scored": In TA calls, we have 4 scorers for each institution/request. To my understanding, now the status of the request is "scored" if only one scorer has finished scoring and therefore indicates that this request is "complete", although not all 4 scorers have finished scoring. So this could be a major issue for TAF admins to check if all requests have really been completely scored. Maybe we can add an additional status "under scoring" as soon as one scorer has scored, and "scored" only if all 4 scorers have scored?

Furthermore, the manual says that admins can check scoring. Do you really mean admins or TAF admins? As so far, this work was done by the TAF amins in the course of preparations for the User Selection Panel.

mmarschler commented 2 years ago

Concerning the visibility of requests in "Requests assigned to me":

Logged in with our Synthesys-Team account, which has among others the roles TA coordinator and TA scorer (see screenshot), I can see under "all requests" all requests for our institution as well as the requests for which I have the scorer role - so this works perfectly fine. 2022-03-02_TA_coordinator_Vienna

2022-03-02_all_requests_Vienna

But when I filter the "Requests assigned to me", I can only see the requests for which I have the scorer role. Here I don't see the requests for our institution anymore: 2022-03-02_requests_assigned_to_me_Vienna

mmarschler commented 2 years ago

One more issue: The manual says that a TA scorer will see TA call requests once the TA call's deadline has passed (see Manual page 51). I was able to score the requests although the call has not ended yet.

mmarschler commented 2 years ago

And could you please give the TAF admin role to our Synthesys-team account synthesys@nhm-wien.ac.at ? Then I will check the soring functionality also from this point of view. Thank you!

cannedit commented 2 years ago

@mmarschler: We never received the ‘requirement’ that TA Call Requests had a fixed amount of TA Scorings as you suggested (4), so the functionality is implemented in such a way that a TA Scoring can happen multiple times (up to the Admins to decide, via assigning TA Scorers). So in case we have to change this set up, then it will mean much more than just adding an extra scoring status. Regarding the statements about TA Scoring in the manual: we will correct them ofc, but there is only a deadline for scoring and the starting date is actually termined by two things: 1. an Admin assigning the TA Scorer role, and 2. the approval of TA Call Requests, so in this sense the Admin actually decides the start of the TA Scoring period. As for you not being able to see anymore requests than the one you are supposed to score, despite the fact that you are also a TA Coordinator: this is the result of mixing these two roles. The original idea was that a TA Scorer should be independent, so not being a TA Coordinator involved in TA Call Requests and thus this is correct. Finally: I have just changed the role of the synthesys@nhm-wien.ac.at account from TA Scorer for Belgium into TAF Admin for Belgium.

LarissaS commented 2 years ago

Hi, I updates the roles and now if I am logged in as TA coordinator I can see requests assigned to me.

Best, Larissa

From: Wim van Dongen @.> Sent: Friday, 25 February 2022 17:02 To: DiSSCo/ELViS @.> Cc: Larissa Smirnova @.>; Comment @.> Subject: Re: [DiSSCo/ELViS] TA Call Request Scoring functionality (Issue #238)

I guess this comment is actually referring to Github issue #236https://github.com/DiSSCo/ELViS/issues/236, but I can react on it over here anyway: it's still the idea that there can only be one TA Coordinator per institution and at the moment both Arnaud Henrard and you hold that role, so please correct this and check again? [Image removed by sender. ELViS_TA_Coordinator_RMC]https://user-images.githubusercontent.com/22167327/155747155-df766197-b822-440e-a326-005f6c00c0a0.png

— Reply to this email directly, view it on GitHubhttps://github.com/DiSSCo/ELViS/issues/238#issuecomment-1050979483, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AAHH3XV7VPRFKLPRDWJYLMLU46RVVANCNFSM5O7GGAJA. Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub. You are receiving this because you commented.Message ID: @.***>

mmarschler commented 2 years ago

@cannedit: It really seems to be an issue of mixed roles. Once I've gave the ta coordinator role away from synthesys@nhm-wien.ac.at to maria.marschler@nhm-wien.ac.at, it worked perfectly fine: Logged in as maria.marschler (ta coordinator), I can see all requests for NHMW (in "All requests" as well as in "Requests assigned to me"). Logged in as synthesys (taf admin for Belgium), I can only see all Belgium requests (in "All requests" as well as in "Requests assigned to me"), but no NHMW requests anymore.

So I think everything is fine now!

LarissaS commented 2 years ago

I have now three roles, @.**@.> as TA coordinator, @.**@.> as requester and @.**@.> as institutional moderator and VA coordinator. As TA coordinator I see all requests assigned to me, as institutional moderator I do not see any TA requests, is it normal? Now Arnaud @.**@.>) is assigned a role of moderator and VA coordinator. Shell we separate these two roles too? Wim, can you give Arnaud a role of TAF administrator, then I can test the scoring functionalities too, if it is still needed of course.

Best, Larissa

From: mmarschler @.> Sent: Tuesday, 8 March 2022 13:03 To: DiSSCo/ELViS @.> Cc: Larissa Smirnova @.>; Comment @.> Subject: Re: [DiSSCo/ELViS] TA Call Request Scoring functionality (Issue #238)

@cannedithttps://github.com/cannedit: It really seems to be an issue of mixed roles. Once I've gave the ta coordinator role away from @.**@.> to @.**@.>, it worked perfectly fine: Logged in as maria.marschler (ta coordinator), I can see all requests for NHMW (in "All requests" as well as in "Requests assigned to me"). Logged in as synthesys (ta scorer for Belgium), I can only see all Belgium requests (in "All requests" as well as in "Requests assigned to me"), but no NHMW requests anymore.

So I think everything is fine now!

— Reply to this email directly, view it on GitHubhttps://github.com/DiSSCo/ELViS/issues/238#issuecomment-1061705263, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AAHH3XVDJBUEHL6OALAMTYDU646WLANCNFSM5O7GGAJA. Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub. You are receiving this because you commented.Message ID: @.***>

B-San-Chi commented 2 years ago

"As it is the same case that happens to Larissa S, in the MNCN there is not a correct assignment of roles and it has caused that in previous TA calls we have had problems. With the idea that there should be only one TA coordinator per institution, this role should only be held by Josefina Cabarga and not by Marian Ramos, since in this way the TA requests reach the wrong person. Wim, could you correctly assign this role only to Josefina and remove it from Marian, as I indicate below?" TA1.pdf TA2.pdf

LarissaS commented 2 years ago

Who assigns the role of score? The manual says admin, but what admin, not TAF admin? Is there already a scorer for Belgium? I can't test the scoring functionality, because I don't even see how can I assign request for scoring!