search

DiSSCo / disscover

Search, discover and act upon data within the DiSSCo digital infrastructure.
https://dev.dissco.tech
Apache License 2.0
1 stars 0 forks source link

home page scrolling issue #55

Closed wouteraddink closed 1 year ago

wouteraddink commented 1 year ago

scrolling down the page seems not possible anymore and the bottom overlaps other elements (tested at dev.dissco.tech)

markuphero-NjpygBd3Fm3kdpwXUvCH

TomDijkema commented 1 year ago

@wouteraddink Should the footer always be visible on the Homepage with a scrollable body, or do you want it to be completely scrollable (scroll down to footer in order to see it)? The Header is static and remains at the top

wouteraddink commented 1 year ago

scroll down to footer, it does not need to be always visible like the header.

On Wed, 6 Sept 2023 at 10:07, TomDijkema @.***> wrote:

@wouteraddink https://github.com/wouteraddink Should the footer always be visible on the Homepage with a scrollable body, or do you want it to be completely scrollable (scroll down to footer in order to see it)? The Header is static and remains at the top

— Reply to this email directly, view it on GitHub https://github.com/DiSSCo/disscover/issues/55#issuecomment-1707869623, or unsubscribe https://github.com/notifications/unsubscribe-auth/AADAUXXTZNCJHANWOWXW4GTXZAVN3ANCNFSM6AAAAAA4L2ZCOQ . You are receiving this because you were mentioned.Message ID: @.***>

-- Coördinator Research-data and E-infrastructure

International Biodiversity Infrastructures Natural Biodiversity Center, P.O. Box 9517, 2300 RA Leiden, The Netherlands

Coordination team member, Distributed System of Scientific Collections ( DiSSCo http://dissco.eu/) Node Manager for DiSSCo, Global Biodiversity Information Facility (GBIF http://www.gbif.org/) Chair Biodiversity Data Integration IG, Research Data Alliance (RDA http://www.rd-alliance.org/)

ORCID: 0000-0002-3090-1761 | Linkedin: linkedin.com/in/wouteraddink/ http://linkedin.com/in/wouteraddink/

Twitter: @wouter99999 | Tel: +31 (0) 71 751 9364

@.*** - www.naturalis.nl - www.catalogueoflife.org - www.dissco.eu

TomDijkema commented 1 year ago

Issue is being picked up on next PR, description of fix:

Commit should fix Github issue https://github.com/DiSSCo/disscover/issues/55. Homepage is a unique scenario in which the page should scroll if the content gets too big for the screen. The Footer gets pushed down to the ultimate bottom and is not always visible unlike the header.

This behavior is not applied to other pages.