search

DiSSCo / openDS

The home of the open Digital Specimen (openDS) specification
Apache License 2.0
17 stars 9 forks source link

ods:livingOrPreserved: can a DigitalSpecimen ever be alive? #140

Open Jegelewicz opened 2 months ago

Jegelewicz commented 2 months ago

Term Name

ods:livingOrPreserved

Digital Object Name

DigitalSpecimen

Feedback

I found it unusual to find this term as a property of DigitalSpecimen. Shouldn't it belong with MaterialEntity? I can't see any way that a DigitalSpecimen could be considered "alive".

Current definition

Whether the specimen is living or preserved

If it must be in DigitalSpecimen perhaps a different definition makes it clearer?

Whether the MaterialEntity associated with the DigitalSpecimen is living or preserved.

Jegelewicz commented 2 months ago

I would make the same observation for ods:isMarkedAsType. The DigitalSpecimen is NOT a type, That status belongs to the MaterialEntity it represents.

Jegelewicz commented 2 months ago

There a lot of term that I feel this way about - I won't keep listing them, but await others' responses.

samleeflang commented 2 months ago

Hi Teresa,

Thanks for your review and valuable comments. We discussed changing our approach to Material Entity. At the moment, we saw DigitalSpecimen as a kind of super class for Material Entity. This would be the main entrance into the specimen data and be filled with the top level specimen. Any material entities that would be part of the main specimen that had not received their own registration number could be described as a Material Entity. However, your comment triggered a rethinking about this part of the model. Seeing the 'main' Material Entity as just one of the Material Entities remove duplicate terms and make us more in line with the TDWG Material Entity. We will remove any terms which feel like they should concern an individual Material Entity, and only leave terms that are concerned with the overall information.

Kind regards, Sam