search

DiUS / java-faker

Brings the popular ruby faker gem to Java
http://dius.github.io/java-faker
Other
4.71k stars 844 forks source link

Soul Knight feature request #723

Open a906358951 opened 2 years ago

a906358951 commented 2 years ago

Is your feature request related to a problem? Please describe. Soul Knight is loved by many young people. It is a classic pixel adventure game with many elements. Please consider adding its feature.

Describe the solution you'd like Characters, Weapons, Statues, Bosses, Enemies, Talents, etc

Uncle-Road commented 2 years ago

@a906358951 hello，i am interested in this feature,and I will try do it

serpro69 commented 2 years ago

It seems that java-faker is not maintained on a regular basis. Would you consider creating a similar PR in https://github.com/serpro69/kotlin-faker instead, @Uncle-Road ? Or else, do you mind if I use the yml files from your PR in the kotlin-faker myself?

Uncle-Road commented 2 years ago

@serpro69 hello, free to use the yml files. And i have to prepare my final exam in recent month.

epragtbeamtree commented 2 years ago

Hi @Uncle-Road , this faker is already part of Datafaker: https://github.com/datafaker-net/datafaker

Uncle-Road commented 2 years ago

Hi @Uncle-Road , this faker is already part of Datafaker: https://github.com/datafaker-net/datafaker

hello,bro. and i check the date and the soulknight.yml. find he is copy my code to soul knight. my code is update in 7 days ago , he is update in 6 days ago , and the yml file is same to me. I am sad and angry because He didn't ask for my permission.

epragtbeamtree commented 2 years ago

Hi @Uncle-Road, my apologies, that 'he' you are referring to is probably me, and I ported this code to Datafaker.

The code is attributed to you, and you are also mentioned in the release notes, but I'm sorry you're angry about this.

Uncle-Road commented 2 years ago

@epragtbeamtree hey, bro. I understand the situation. There may be some misunderstanding between us. If you mention me in the release notes, it will be fine. And I saw your comment, misunderstood your meaning before

epragtbeamtree commented 2 years ago

@Uncle-Road oki, no worries, just want to make sure I don't step on anyone's toes. I love your contributions, and it's a shame javafaker is dead, but we're trying to continue the journey at Datafaker, and kotlin-faker seems like a great project too!

Uncle-Road commented 2 years ago

@epragtbeamtree Actually javafaker is an open-source project required by my software engineering course at SUSTech. We're nearing the end of the semester, and I'll be putting my previous PRs into these two newest projects(Datafaker, kotlin-faker) over the summer vacation, and I've been preparing for my final exams recent month.

bodiam commented 2 years ago

@Uncle-Road would it be an option to suggest Datafaker as an alternative at your course? I'm even happy to assist students in their work if needed.

Uncle-Road commented 2 years ago

@bodiam hey, bro. Thanks for your suggestion. And I will report this situation to the teacher Mrs. Chen and ask her to replace it with datafaker next semester. (The number of issues is very important for Mrs. Chen to choose projects. Could you consider mentioning more issues)

bodiam commented 2 years ago

@Uncle-Road that would be amazing, thank you. There's a long list of fakers which will need implementing, and they make excellent candidates for a engineering course. You can send me an email if you need a list, or I can make a list of issues specifically for you. I think I can make 30 or 40 issues easily, and mark them as reserved for you.

Lastly, I want to thank you for how you handled our earlier miscommunication. That was incredibly mature, and I appreciate it.