RequireJS is out - Githubissues

DiUS / pact-consumer-js-dsl

*DEPRECATED* A Javascript DSL for creating pacts, superceded by Pact JS

https://github.com/pact-foundation/pact-js

Other

56 stars 26 forks source link

RequireJS is out #12

Closed tarciosaraiva closed 9 years ago

tarciosaraiva commented 9 years ago

Hi so a couple of things I changed:

Removed RequireJS
Also removed the RequireJS example folder (didn't seem relevant anymore / too hard to change)
Removed Grunt
Introduced Gulp
Introduced jshint for code quality
Integrated Gulp with Karma + Bundle
Updated README
Split the README into other 2 files: CONTRIBUTING and ROADMAP

I'm not sure if there's a CI hooked to it yet but, if it does, then you will have to change the test run with the command line gulp run-tests ci

Not sure if we should commit the dist file of pact js but, if you feel like, we can change this easily.

Guess that's that :)

bethesque commented 9 years ago

Looks great! I think we need the dist directory though - it's where npm pulls the pact-js-dsl file from.

bethesque commented 9 years ago

Or, I thought it did...

tarciosaraiva commented 9 years ago

Cool, no worries. I will send a new pull request for that.

Out of curiosity, where bower fits into the picture? It's used to manage UI dependencies and well.. we have none! :D

bethesque commented 9 years ago

No idea. Malinda might know! I think I've put the dist back in already.

On Fri, Dec 19, 2014 at 3:42 PM, Tarcio Saraiva notifications@github.com wrote:

Cool, no worries. I will send a new pull request for that.

Out of curiosity, where bower fits into the picture? It's used to manage UI dependencies and well.. we have none! :D

— Reply to this email directly or view it on GitHub https://github.com/DiUS/pact-consumer-js-dsl/pull/12#issuecomment-67597918 .