search

DiUS / pact-consumer-js-dsl

*DEPRECATED* A Javascript DSL for creating pacts, superceded by Pact JS
https://github.com/pact-foundation/pact-js
Other
56 stars 26 forks source link

Add eachLike array flexible matcher #45

Closed michaelisgro closed 8 years ago

michaelisgro commented 8 years ago

Added Pact.Match.eachLike matcher.

Note: this build will not pass until https://github.com/bethesque/pact-support/pull/10 has been incorporated into the next gem versions (pact-support and pact-mock-service) and we update the Gemfile.

cc: @mefellows

bethesque commented 8 years ago

Happy to merge once the Travis CI build is passing - can you investigate @michaelisgro? I've released a new version of pact-support, so it should have been picked up.

mefellows commented 8 years ago

@michaelisgro Run bundle update pact-support and commit the updated Gemfile.lock. Just tested locally on your branch and tests pass.

michaelisgro commented 8 years ago

Updated to check that eachLike minimum is greater than 0

cc: @mefellows

bethesque commented 8 years ago

@michaelisgro I can't see another commit, there's only one in the history.

mefellows commented 8 years ago

We squashed it - but the change is in there :)

davidchin commented 8 years ago

@bethesque I saw you bumped bower.json to v0.2.1, which contains this change. However, I think you probably forgot to tag it on Github. Could you please tag it so that it works with bower install? Thanks!

mefellows commented 8 years ago

@davidchin done