DiUS / pact-website

0 stars 2 forks source link

Added a time zone drop down to the register page #3

Closed TimothyJones closed 5 years ago

TimothyJones commented 7 years ago

This adds a time zone drop down to the register page, using the jQuery plugin select2. This fixes #1.

There's a corresponding change (untested) in the lambda, which will need to be tested and pushed to the server.

An additional improvement would be to augment the time zone keys (which are created by Ruby's time zone list) with better human readable time zones.

bethesque commented 7 years ago

I'm going to have to get this set up on my local machine now. Will review as soon as I can. Thanks so much!

mefellows commented 7 years ago

@bethesque do we still need/want this?

bethesque commented 7 years ago

Yes, I'd still like it! I keep meaning to merge it in, but it didn't hit the top of the priority list.

On Thu, Aug 10, 2017 at 5:16 PM, Matt Fellows notifications@github.com wrote:

@bethesque https://github.com/bethesque do we still need/want this?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/DiUS/pact-website/pull/3#issuecomment-321471444, or mute the thread https://github.com/notifications/unsubscribe-auth/AAbPFLBQ7V7yGrpwzTyQ5CuSjtoKReG2ks5sWq5FgaJpZM4NknWh .

--

Bethany Skurrie

Software Developer

Phone: 03 9008 5400

LinkedIn: au.linkedin.com/in/bethanyskurrie

Twitter: @bethesque https://twitter.com/bethesque

This email is intended solely for the use of the addressee and may contain information that is confidential or privileged. If you receive this email in error please notify the sender and delete the email immediately.

mefellows commented 5 years ago

It was a fun ride ;)