search

DiUS / pact-workshop-js-v1

Original Example JS project for the Pact workshop
Apache License 2.0
95 stars 42 forks source link

Cannot get this to work #8

Closed BrendonFlanagan closed 5 years ago

BrendonFlanagan commented 5 years ago

Upon checking out the latest, there are still some minor typos, but I can only get as far as Step 3 and simply cannot get the pact to validate.

Can you please re-test this yourself and provide an updated starting point and step by step guide. Please, please, please.

mefellows commented 5 years ago

Clean checkout of step 3, ensuring no artefacts remain from previous steps:

screenshot

If there are minor typos, we'd love feedback/PR to fix them!

Are you able to please show what's not working and we can go from there? I ran this workshop in November and we didn't have any issues on this step.

Also, any OS and other relevant detail would be helpful.

BrendonFlanagan commented 5 years ago

Possibly best to start from the beginning as maybe thats where it begins to go wrong.

Downloaded the zipped version.

At step 1

Running

$ node provider/provider.js

Does nothing, but $ node provider/providerService.js works

Provider Service listening on http://localhost:9123

Then

$ node consumer/consumer.js { test: 'NO', validDate: '2017-06-12T06:25:42.392Z', count: 100 }

Doesn't produce the above, it instead produces

{ count: 0.1, date: '2019-02-27T20:37:18+13:00' }

I've attached the zip file so you can confirm.

Thanks

Brendon.

On 26 February 2019 at 23:22 Matt Fellows notifications@github.com wrote:

Clean checkout of step 3, ensuring no artefacts remain from previous steps:

[screenshot] https://user-images.githubusercontent.com/53900/53405644-60d37480-3a0c-11e9-9644-70c2d07eb363.png

If there are minor typos, we'd love feedback/PR to fix them!

Are you able to please show what's not working and we can go from there? I ran this workshop in November and we didn't have any issues on this step.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/DiUS/pact-workshop-js/issues/8#issuecomment-467382703 , or mute the thread https://github.com/notifications/unsubscribe-auth/AtyhEh7vgzDrHpERUapZlUB4-KjZV6zTks5vRQrQgaJpZM4bRy04 .
mefellows commented 5 years ago

Downloaded the zipped version.

You can't do this. You need to use git, as each step is tied to a branch in the git repository.

I realise this may not be obvious to others, and so will add a note to the top of the readme now..

mefellows commented 5 years ago

I've just made a small update to the readme. Hopefully this gets you moving, apologies for any confusion.

BrendonFlanagan commented 5 years ago

Cool, thanks for that, I only had time to do step 1 tonight, worked as expected, so I should be all good now.

Brendon.

On 27 February 2019 at 21:55 Matt Fellows notifications@github.com wrote:

I've just made a small update to the readme. Hopefully this gets you moving, apologies for any confusion.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/DiUS/pact-workshop-js/issues/8#issuecomment-467778430 , or mute the thread https://github.com/notifications/unsubscribe-auth/AtyhEn3sgCmJXthabW8aYaRtgD138KSPks5vRkgcgaJpZM4bRy04 .
mefellows commented 5 years ago

No dramas. If you haven't already, worth jumping into slack.pact.io and joining the community :)