DiUS / pact_broker-docker

'Dockerised' pact broker
http://pact.io
MIT License
76 stars 102 forks source link

docker image does not create/seed sqlite database out of the box #102

Closed pniederlag closed 3 years ago

pniederlag commented 3 years ago

Pre issue-raising checklist

I have already (please mark the applicable with an x):

Expected behaviour

docker run --name=packt-broker --rm -ti -e PACT_BROKER_DATABASE_ADAPTER=sqlite -e PACT_BROKER_DATABASE_NAME=test.sqlite docker.io/dius/pact-broker

Should start a docker container that ist just usable right away

Actual behaviour

Steps to reproduce

use above docker run command

To get it running:

bethesque commented 3 years ago

Sqlite is only to be used inside the container for demo purposes. There is no production use case for this scenario. Try putting the database in the /tmp directory, as the home directory is probably not writeable for security purposes.

pniederlag commented 3 years ago

thx for your feedback @bethesque

I understand the container is intended for production use and certainly sqlite is not meant to be used in production environments.

please consider also people using this image for evaluation purposes, where sqlite in general is a pretty good choice as it requires way less work for setup und persistence, performance and alike are neglectible when spinning up a container for a quick glance.

If the container is not be used for evaluation or simple out-of-the-box functionality in combination with sqlite it would be advisable to indicate this in the README. Would maybe save some others folks some time spent in debugging/analysis ;)

bethesque commented 3 years ago

I think most people use the docker-compose file, or mount a directory from a local volume, which is why this hasn't come up before. I've seen your note for an update in the readme, thanks.