search

DiUS / pact_broker-docker

'Dockerised' pact broker
http://pact.io
MIT License
76 stars 102 forks source link

Upgrade to latest phusion passenger ruby image #111

Closed nateg-gladly closed 2 years ago

nateg-gladly commented 2 years ago

What

Upgrade to the latest phusion passenger ruby27 docker image. The latest tag is 2.01 as shown here: https://hub.docker.com/r/phusion/passenger-ruby27/tags

It looks like the changelog for the 1.x to 2.x release is here: https://github.com/phusion/passenger-docker/blob/master/CHANGELOG.md

Why

2.x releases have a fix for this issue: https://github.com/phusion/passenger/issues/2303

We ran into this in the dius/pact-broker:2.89.1.0 image: in that image running an apt-get update && upgrade runs into this error:

Reading package lists...                                                                                                                       
E: The repository 'https://oss-binaries.phusionpassenger.com/apt/passenger focal Release' does not have a Release file.
bethesque commented 2 years ago

Awesome! Thank you so much for this. Looks like nothing is actually a breaking change, despite the major version bump.

bethesque commented 2 years ago

I had to revert this due to the build failing https://github.com/DiUS/pact_broker-docker/runs/4173742227?check_suite_focus=true

Not sure why it didn't run for the branch.

bethesque commented 2 years ago

I've updated the build workflow to run for pull requests. Would you please re-open the request?

nateg-gladly commented 2 years ago

Thanks, re-opened! https://github.com/DiUS/pact_broker-docker/pull/113