Closed patvong closed 5 years ago
I can't accept this PR to master as it will break all our existing users. I could accept it to a branch, and then see if we can tag builds from that branch differently in dockerhub.
I can't accept this PR to master as it will break all our existing users. I could accept it to a branch, and then see if we can tag builds from that branch differently in dockerhub.
Sure, PR to another branch makes total sense. There's the Travis CI build as well that would need to be modified as the test scripts try to reach to the 80 port instead of 8080.
Can you update the travis tests please @patvong? I'll do a manual merge of this into a different branch when that's passing.
Ping me when it's done, because I won't get any notifications that there are new commits or that it's passing.
Also had a go trying to get this working on k8s - hit the same problem: from what I can see the only breaking change should be the exposed port, is that not something that could be done in a major version release?
I'm not going to break the current docker image, but I will put this on a branch, and release a version with a different tag. Just waiting for those tests @patvong
Closing this PR, please refer to https://github.com/DiUS/pact_broker-docker/pull/87
Description
We have
pactbroker
running on our kubernets cluster currently as root using the image https://hub.docker.com/r/dius/pact-broker/dockerfile. Our k8s admin want to enforce a security context configuration to have the pods all running as non-root.Since the Docker
pact_broker-docker
image is based offphusion/passenger-ruby24:1.0.0
which runsCMD ["/sbin/my_init"]
which requires a root user for many things. To workaround many issues (requiring root), I had to modify the Dockerfile to be able to run as non-root with userapp
:app
user to theroot
groupI tested this docker image with the k8s manifest configuration as follow:
pactbroker.yml
postgres.yml
Running in kubernetes