search

DiabetesCompass / Diabetes_Compass

iOS code for type 1 diabetes management
MIT License
4 stars 0 forks source link

FontAwesome icons not showing on buttons #2

Closed calferness closed 7 years ago

beepscore commented 7 years ago

Fixed at least some of these e.g. commits 5d991f3, 8b532c4, 1f42095

beepscore commented 7 years ago

Clif, do you see any other buttons that are missing icons?

calferness commented 7 years ago

Yes, in the trends screen, if you click on either the BG container or the HA1c container, It brings up a core plot screen of the historical data. There should be a return icon for each of those screens. They don’t show up, at least on my SE. Clif Alferness 13143 Shoreline DR SE Olalla, WA, 98359 mobile 206 229 1363

calferness@gmail.com mailto:clif@calferness.com

On Nov 14, 2016, at 9:09 PM, Steve Baker notifications@github.com wrote:

Clif, do you see any other buttons that are missing icons?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/calferness/compass_rose-master/issues/2#issuecomment-260548823, or mute the thread https://github.com/notifications/unsubscribe-auth/AGLuZAE87E9vgQrnKCj2lDVGipyQLtbFks5q-T6KgaJpZM4KnnHV.

beepscore commented 7 years ago

Is this using the commits I made tonight?

Steve Baker

On Nov 14, 2016, at 9:38 PM, Clif Alferness notifications@github.com wrote:

Yes, in the trends screen, if you click on either the BG container or the HA1c container, It brings up a core plot screen of the historical data. There should be a return icon for each of those screens. They don’t show up, at least on my SE. Clif Alferness 13143 Shoreline DR SE Olalla, WA, 98359 mobile 206 229 1363

calferness@gmail.com mailto:clif@calferness.com

On Nov 14, 2016, at 9:09 PM, Steve Baker notifications@github.com wrote:

Clif, do you see any other buttons that are missing icons?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/calferness/compass_rose-master/issues/2#issuecomment-260548823, or mute the thread https://github.com/notifications/unsubscribe-auth/AGLuZAE87E9vgQrnKCj2lDVGipyQLtbFks5q-T6KgaJpZM4KnnHV.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

calferness commented 7 years ago

Yes, I think so. I'm a bit uncertain about using the Source Tree as to just what happens. I may need another short tutorial to be certain. I did notice that the menu icon moved a bit to the left.

Sent from my iPhone

On Nov 14, 2016, at 9:48 PM, Steve Baker notifications@github.com wrote:

Is this using the commits I made tonight?

Steve Baker

On Nov 14, 2016, at 9:38 PM, Clif Alferness notifications@github.com wrote:

Yes, in the trends screen, if you click on either the BG container or the HA1c container, It brings up a core plot screen of the historical data. There should be a return icon for each of those screens. They don’t show up, at least on my SE. Clif Alferness 13143 Shoreline DR SE Olalla, WA, 98359 mobile 206 229 1363

calferness@gmail.com mailto:clif@calferness.com

On Nov 14, 2016, at 9:09 PM, Steve Baker notifications@github.com wrote:

Clif, do you see any other buttons that are missing icons?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/calferness/compass_rose-master/issues/2#issuecomment-260548823, or mute the thread https://github.com/notifications/unsubscribe-auth/AGLuZAE87E9vgQrnKCj2lDVGipyQLtbFks5q-T6KgaJpZM4KnnHV.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

calferness commented 7 years ago

Hmmm… I tried it again on the SE simulator and it worked great, with return icons on both screens. Then tried it deployed on my SE and it also worked fine. Not sure what I did wrong last night, but your fix was perfect. Clif Clif Alferness 13143 Shoreline DR SE Olalla, WA, 98359 mobile 206 229 1363

calferness@gmail.com mailto:clif@calferness.com

On Nov 14, 2016, at 9:48 PM, Steve Baker notifications@github.com wrote:

Is this using the commits I made tonight?

Steve Baker

On Nov 14, 2016, at 9:38 PM, Clif Alferness notifications@github.com wrote:

Yes, in the trends screen, if you click on either the BG container or the HA1c container, It brings up a core plot screen of the historical data. There should be a return icon for each of those screens. They don’t show up, at least on my SE. Clif Alferness 13143 Shoreline DR SE Olalla, WA, 98359 mobile 206 229 1363

calferness@gmail.com mailto:clif@calferness.com

On Nov 14, 2016, at 9:09 PM, Steve Baker notifications@github.com wrote:

Clif, do you see any other buttons that are missing icons?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/calferness/compass_rose-master/issues/2#issuecomment-260548823, or mute the thread https://github.com/notifications/unsubscribe-auth/AGLuZAE87E9vgQrnKCj2lDVGipyQLtbFks5q-T6KgaJpZM4KnnHV.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/calferness/compass_rose-master/issues/2#issuecomment-260553410, or mute the thread https://github.com/notifications/unsubscribe-auth/AGLuZFqXs2zFzjO_r9qtAaF7FOrqkr7Pks5q-UeYgaJpZM4KnnHV.