search

DiabetesCompass / Diabetes_Compass

iOS code for type 1 diabetes management
MIT License
4 stars 0 forks source link

Return icon not visible in BG or HA1c trends screens #25

Closed calferness closed 7 years ago

calferness commented 7 years ago

There is supposed to be an icon in the lower right corner of the BG trends and HA1c trends screens that switches them back to the trends screen. I think this is supposed to be a navigation bar button item. It doesn't appear on the screens.

beepscore commented 7 years ago

Currently I don't understand why trendsButton isn't visible. In storyboard I set trendsButton type to custom with custom fontAwesome, instead of in code. For a while I could see it with desired list icon, but while tinkering the position was at top left. I tried programmatically moving button to the front. I didn't commit this. It might be easiest to replace the frame dimension code with autolayout constraints, but this could be a lot of work. Also I think iPhone 6 simulator shows app at less than full height of screen.

calferness commented 7 years ago

I just pulled it again and ran it on my SE, which is the same screen size as an iPhone 5. It all sure does look nice on that screen, although the back button still is not visible! I’ve noticed that it seems to clip parts of the plot images too, particularly on the right side of the screen. For example, the arithmetic mean historical BG is meant to be displayed on the right side of the trends screen, but mine only shows 1 1/2 digits. Back when those kids wrote the original code, it was probably targeted for iPhone 4 and iPad 2 (maybe). Over the past year, I have tried numerous times to use the auto layout & constraints with out much luck. Always seems to work fine on one simulator and messed up on others. I probably just don’t understand how the constraints work. I think they’re supposed to make it so the appearance is very similar regardless of the device on which it’s deployed. Clif P.S. Just got a note from Stefan Kramer. He’s doing well. Clif Alferness 13143 Shoreline DR SE Olalla, WA, 98359 mobile 206 229 1363

calferness@gmail.com mailto:clif@calferness.com

On Nov 13, 2016, at 12:53 AM, Steve Baker notifications@github.com wrote:

Currently I don't understand why trendsButton isn't visible. In storyboard I set trendsButton type to custom with custom fontAwesome, instead of in code. For a while I could see it with desired list icon, but while tinkering the position was at top left. I tried programmatically moving button to the front. I didn't commit this. It might be easiest to replace the frame dimension code with autolayout constraints, but this could be a lot of work. Also I think iPhone 6 simulator shows app at less than full height of screen.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/calferness/compass_rose-master/issues/25#issuecomment-260174003, or mute the thread https://github.com/notifications/unsubscribe-auth/AGLuZPc_e5nwSgx55Czim8RlR7CJxVxzks5q9s_3gaJpZM4KwJQz.

beepscore commented 7 years ago

Fixed in git commit #a1cd2c4 added Launch Screen. http://stackoverflow.com/questions/32312906/ios9-app-has-black-bars-on-top-and-bottom

Now many screens are close to correct size on iPhone 6 simulator. However in several views, elements are out of place. Subsequent commits added layout constraints to reposition some of them.