Diablo-D3 / DiabloMiner

OpenCL miner for Bitcoin
https://bitcointalk.org/index.php?topic=1721.0
GNU General Public License v3.0
538 stars 217 forks source link

Getwork seems to be broken #21

Closed edgeman16 closed 13 years ago

edgeman16 commented 13 years ago

One of the changes made on 2011-06-23 seems to have broken DiabloMiner with my mining proxy:

[6/24/11 1:03:44 PM] ERROR: Cannot connect to Bitcoin: Bitcoin returned error message: Work not found in proxy database.

This was not occurring with the previous version of Diablo-Miner.

Diablo-D3 commented 13 years ago

Its probably exposing a bug in your proxy that doesn't handle time incrementing correctly.

cdhowie commented 13 years ago

What mechanism does the miner use to determine if the pool/bitcoind supports this feature? If possible I would like to make sure that workers know that the proxy doesn't support this feature until it becomes supported.

Diablo-D3 commented 13 years ago

My miner currently does not attempt detecting if the pool or proxy doesn't support it. I do not wish to maintain a blacklist.

The alternative, btw, is turning off ntime incrementing on nonce saturation, but then the miner threads will just block, which is what I was fixing to begin with. Queuing unused getworks is not a viable alternative.

cdhowie commented 13 years ago

I meant by inspecting the X-Roll-NTime header, and disabling this behavior if it is not present, not by keeping a blacklist.

Diablo-D3 commented 13 years ago

I may consider it at some point, but only when all major pools support the header. Until then, people will rarely get a broken share now and then.