search

Diablo-D3 / DiabloMiner

OpenCL miner for Bitcoin
https://bitcointalk.org/index.php?topic=1721.0
GNU General Public License v3.0
538 stars 217 forks source link

Gracefully handle H != 0 targets #34

Closed forrestv closed 12 years ago

Diablo-D3 commented 12 years ago

Has this patch been tested on a chain of less than diff 1? It looks like it will just refuse to sendwork if diff is less than 1 with your change (although its not like my code any better, diff 1 is never supposed to happen on the main chain)

forrestv commented 12 years ago

I hadn't tested it, but I just did and it works. I think you're reading it backwards - it will always sendwork if diff is less than 1 with my change.

Diablo-D3 commented 12 years ago

I suspect I am reading it backwards. Although, this patch doesn't fix the fact that the miner will still only turn in far fewer shares than it should at <1 diff. I will merge it anyways.