search

DiamondLightSource / FastCS

Control system agnostic framework for building device support in Python for both EPICS and Tango
Apache License 2.0
1 stars 2 forks source link

Add HTTPConnection #18

Closed GDYendell closed 6 months ago

codecov[bot] commented 7 months ago

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (497316c) 45.19% compared to head (44d3d90) 45.15%.

Files Patch % Lines
src/fastcs/connections.py 43.75% 9 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #18 +/- ## ========================================== - Coverage 45.19% 45.15% -0.04% ========================================== Files 17 17 Lines 624 640 +16 ========================================== + Hits 282 289 +7 - Misses 342 351 +9 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

GDYendell commented 6 months ago

It has become clear that needs to be eiger-specific. It could possibly be refactored into a shared base class when we have a second use case.