DiamondLightSource / FastCS

Control system agnostic framework for building device support in Python for both EPICS and Tango
Apache License 2.0
1 stars 2 forks source link

Add ZMQ Connection support #21

Closed OCopping closed 4 months ago

OCopping commented 7 months ago

This will add an Asynchronous ZMQ Connection class to FastCS connections.

codecov[bot] commented 7 months ago

Codecov Report

Attention: Patch coverage is 27.73109% with 86 lines in your changes are missing coverage. Please review.

Project coverage is 41.32%. Comparing base (7a70b95) to head (682d97e). Report is 1 commits behind head on create-connections-dir.

Files Patch % Lines
src/fastcs/connections/zmq_connection.py 25.86% 86 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## create-connections-dir #21 +/- ## ========================================================== - Coverage 43.79% 41.32% -2.48% ========================================================== Files 17 19 +2 Lines 653 772 +119 ========================================================== + Hits 286 319 +33 - Misses 367 453 +86 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

GDYendell commented 7 months ago

@OCopping can I assume this isn't ready to be reviewed until you remove the draft?