LIMS-1200: CSV file upload ignores first sample

[ndg63276]

JIRA ticket: LIMS-1200

Summary:

One way to create multiple simple samples (for XPDF) is to upload a CSV file. A header row is compulsory and provided in the template, and is stripped by the CSV file library. However, the Synchweb code also strips the first subsequent row, meaning the first user sample is ignored.

Changes:

• No longer ignore the first row of the CSV file

To test:

• On the dev db:
  • Go to proposal cm37261
  • Select Phases from the main menu
  • Click on a phase eg H2O.1
  • Click "Add new simple sample"
  • Choose "File upload for multiple samples"
  • Select this file simple_sample_csv_template.csv
  • Choose a plain capillary eg "Borosilicate 1mm OD"
  • Click "Add Sample".
  • Go to Samples from the main menu, see if all 4 were added

[gfrn]

May I suggest we include a change to line 729 of vue-simplesample.vue as well? It throws an error if csvData has a length of one, which also prevents users from uploading a single simple sample.

My suggestion is to make line 729 the following:

if(self.csvData.length < 1 && self.csvErrors.length === 0){
    self.csvErrors.push("Only headers have been submitted, please add some sample information")
}

I'm happy to make a PR for this PR if that's not a problem

(To reproduce this issue, repeat all steps in the original PR description, but use simple_sample_csv_template(1).csv instead)

[ndg63276]

Yep, good spot! Have added that fix.