LIMS-1174: Handle blank proposal on visits page - Githubissues

DiamondLightSource / SynchWeb

ISPyB web application

http://diamondlightsource.github.io/SynchWeb/

Apache License 2.0

15 stars 31 forks source link

LIMS-1174: Handle blank proposal on visits page #740

Closed ndg63276 closed 6 months ago

ndg63276 commented 7 months ago

JIRA ticket: LIMS-1174 Github issue: https://github.com/DiamondLightSource/SynchWeb/issues/133

Summary:

If you end up on the visits page without a current proposal, you get a server error. This should be handled more gracefully.

Changes:

Handle the error in PHP
Redirect to the proposals page in JS

To test:

Log in to Synchweb, but dont choose a proposal. Go to /visits/. It should redirect you to the proposals page.