LIMS-1256: Remove validation from Local Contact field

DiamondLightSource / SynchWeb

ISPyB web application

http://diamondlightsource.github.io/SynchWeb/

Apache License 2.0

15 stars 31 forks source link

LIMS-1256: Remove validation from Local Contact field #756

Closed ndg63276 closed 7 months ago

ndg63276 commented 7 months ago

JIRA ticket: LIMS-1256

Summary:

A user couldn't fill in the dispatch request form because the local contact had an "ö" in their name and the form rejected the "ö". As the user cannot edit this field any more, we should remove the validation.

Changes:

Remove validation from local contact field
Remove wwsddash pattern as it is not used anywhere else

To test:

Do a dispatch request, check the form still submits ok

gfrn commented 7 months ago

Should we also apply this to the "full name" field in the contact details form?

ndg63276 commented 7 months ago

Potentially, but I think not right now. Obviously people might be unhappy if they cannot fill in their name with accents, umlauts etc, but it is at least editable so they can sanitise their name to fit the requirements. And we probably need some validation on the field.