DiamondLightSource / SynchWeb

ISPyB web application
http://diamondlightsource.github.io/SynchWeb/
Apache License 2.0
15 stars 31 forks source link

LIMS-656: Show auto subsamples if they have data #817

Closed ndg63276 closed 1 month ago

ndg63276 commented 2 months ago

JIRA ticket: LIMS-656

Summary:

If a subsample on a plate has an associated data collection, then it should always be shown, even if it is from an old inspection.

Changes:

To test:

gfrn commented 2 months ago

Well 1 seems to have one extra subsample (10 items are shown in the list), is that because new data was inserted since this ticket was created?

As an aside, clicking the "view collected data" button on a subsample, then clicking the permalink button, leads to an oddly placed modal being present, although this has no effect on the changes presented in this ticket.

ndg63276 commented 2 months ago

Well 1 seems to have one extra subsample (10 items are shown in the list), is that because new data was inserted since this ticket was created?

Sorry, I didn't word it very well. Well 1 should have 10 items before and after this change. Well 169 should have 5 items before, and 9 items after this change.