search

DiamondLightSource / aioca

Asynchronous Channel Access client for asyncio and Python using libca via ctypes
Apache License 2.0
6 stars 3 forks source link

Adopt copier template #52

Open AlexanderWells-diamond opened 1 day ago

AlexanderWells-diamond commented 1 day ago

A fair amount of manual work went in to fixing the Docs, to make the existing .rst work with the new .md format. The new documentation should be reviewed to check it is sensible.

codecov[bot] commented 1 day ago

Welcome to Codecov :tada:

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered :open_umbrella:

AlexanderWells-diamond commented 1 day ago

@coretl The remaining errors are a handful of new linting errors, and a single test failure.

The linting errors are mostly regarding accessing private members, which would require actual code changes to fix.

The one test failure is strange - it's completely repeatable, but only after the copier template has been applied. I can't see any obvious packages that would cause it (I tried rolling back epicscorelibs and various pytest-* dependencies). It passed here a few months ago.

How do you want me to handle these issues?

AlexanderWells-diamond commented 9 hours ago

After discussion with @coretl I mostly ignored the linting errors, and then spent some time investigating the test failure and applying a (hacky) fix to it. This is now ready for review.