DiamondLightSource / blueapi

Apache License 2.0

3 stars 5 forks source link

Add CLI tests or exclude CLI directory from code coverage #256

Open DiamondJoseph opened 1 year ago

DiamondJoseph commented 1 year ago

CLI calls to CLI REST client calls to REST API calls into code. Mocking out the REST API to ensure that the CLI is calling the correct endpoints would be a useful sanity check. Currently CLI + CLI REST client adds ~3 lines of uncovered "code" for every endpoint which brings down the reported code coverage of functional code. Is there an easy way to test Click commands in situ?

Or: Move CLI client into its own repository?

stan-dot commented 6 months ago

connected to #242

stan-dot commented 4 months ago

364 is very closely connected

stan-dot commented 3 months ago

doing this functionality as part of the autogenerated client part in #441

stan-dot commented 3 months ago

Mocking out the REST API to ensure that the CLI is calling the correct endpoints would be a useful sanity check. that is effectively done in #441 , we could close this as redundant

stan-dot commented 3 months ago

will do this after migration to pydantic 2 #449 and code auto gen ( #364 )