DiamondLightSource / blueapi

Apache License 2.0
3 stars 5 forks source link

Add stage to release pipeline to pin dependencies #271

Closed DiamondJoseph closed 2 months ago

DiamondJoseph commented 1 year ago

Allows dev to continue with latest version of dependencies and prevent us slipping further and further behind the wider world, while also providing a known working state when releasing.

stan-dot commented 6 months ago

@DiamondJoseph how would this look technically? a line in pyproject.toml?

stan-dot commented 3 months ago

@DiamondJoseph what's your current take on this?

DiamondJoseph commented 3 months ago

I haven't done any more thinking about it. Hopefully now that ophyd-async is trending towards stability it shouldn't be required now?

DiamondJoseph commented 3 months ago

I'd say not to focus on it right now

stan-dot commented 3 months ago

@DiamondJoseph have you known about this file when raising the issue? see lines 50 to 65

DiamondJoseph commented 3 months ago

@stan-dot This issue was raised in July 2023, that file was added to the repository 3 months ago. Causality demands that no I didn't know ;)

stan-dot commented 3 months ago

ok, should we close this?

stan-dot commented 2 months ago

looking at the base issue

Allows dev to continue with latest version of dependencies and prevent us slipping further and further behind the wider world, while also providing a known working state when releasing.

@callumforrester do you disagree with the premise? I heard that there are divergent viewpoints design-and-workflow in regards to dependencies

callumforrester commented 2 months ago

@stan-dot I agree with this premise for applications, at least

stan-dot commented 2 months ago

ok, and this is blueapi, which is an application. Can we merge #499 now @DiamondJoseph ?

DiamondJoseph commented 2 months ago

@stan-dot sure, let's see how Dependabot keeps up, I'll make some time next week to have a look at its configuration