search

DiamondLightSource / blueapi

Apache License 2.0
6 stars 6 forks source link

Fix reloading the environment if there is an error #514

Closed joeshannon closed 3 months ago

joeshannon commented 3 months ago

This adds a new error field to the environment. This is now checked against when attempting to delete the environment as if there is an error the handler is never set to initialized.

Note that the property has only been added to SubprocessHandler as the BlueskyHandler ABC is likely to be removed.

Fixes #512.

joeshannon commented 3 months ago

I have only added the error property to the subprocess handler (and not the ABC).

Looking at the test failures now it seems the handler implementation is variable, perhaps I should just add to the ABC.

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 91.10%. Comparing base (2c84311) to head (416ffc5).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #514 +/- ## ========================================== + Coverage 91.06% 91.10% +0.04% ========================================== Files 40 40 Lines 1779 1787 +8 ========================================== + Hits 1620 1628 +8 Misses 159 159 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.