search

DiamondLightSource / blueapi

Apache License 2.0
3 stars 5 forks source link

Investigate splitting into many packages with a shared Dockerfile-base #562

Closed stan-dot closed 4 weeks ago

stan-dot commented 1 month ago

what is interesting and necessary to get a clear answer on is how are plans defined? they cannot be serialized

stan-dot commented 1 month ago

the list of necessary changes is in the todo.md file. This awaits the #363

stan-dot commented 1 month ago

@callumforrester this is required for the scenario where the rest api to run in the central cluster while the worker runs on the beamline. do you have any preferences wrt implementation?

callumforrester commented 1 month ago

@stan-dot I don't think this is a requirement. For a first implementation having both in one image is fine, and we can run either blueapi worker or blueapi job_manager or something like that.

stan-dot commented 1 month ago

that is fair. the only drawback is the image size going slightly up, maybe different if dependencies are counted. Can we close this then as not planned?

callumforrester commented 4 weeks ago

Will do, I suggest we raise a separate issue about image size optimisation when we decide that is a problem