search

DiamondLightSource / blueapi

Apache License 2.0
6 stars 6 forks source link

Configure CodeQL and sonarcloud #595

Closed stan-dot closed 1 month ago

stan-dot commented 2 months ago

following the outline in the suggestion to add those tools to the copier template - it should be tested first https://github.com/DiamondLightSource/python-copier-template/issues/180

a link to the current report could be provided in the README

stan-dot commented 2 months ago

@callumforrester re: sonarcloud - I was only able to request and expected an email to be sent to DLS org maintainers, but instead it redirected, expecting me to auth into this https://sonarcloud.io/login?return_to=%2Fcreate-organization%3Finstallation_id%3D10497114%26setup_action%3Dupdate&error=authentication

callumforrester commented 2 months ago

@stan-dot strange, you were able to request it for other repos, correct?

stan-dot commented 2 months ago

it might be complicated

stan-dot commented 2 months ago

waiting for @callumforrester 's reponse

callumforrester commented 2 months ago

Approved

stan-dot commented 1 month ago

I realized that sonarcloud was not visible, and the adding process as 'github app' was a bit magic.

there is also an option to configure it with a github action, which is more aligned with how other similar tools are used at DLS. Investigating that setup now

stan-dot commented 1 month ago

https://github.com/marketplace/actions/sonarcloud-scan