DiamondLightSource / blueapi

Apache License 2.0
3 stars 5 forks source link

Move to pyright #619

Open callumforrester opened 2 weeks ago

callumforrester commented 2 weeks ago

Acceptance Criteria

stan-dot commented 1 week ago

at the moment, python-copier-template pyproject.toml does not contain references to pyright, neither does it have it as a dev dependency

https://github.com/DiamondLightSource/python-copier-template/blob/main/pyproject.toml

callumforrester commented 1 week ago

@stan-dot That is for setting up a dev environment to build/test the template, it is not the file used to make projects, you're looking for this: https://github.com/DiamondLightSource/python-copier-template/blob/main/template/pyproject.toml.jinja

stan-dot commented 1 week ago

ah right, so we need to add pyright to the dev dependencies, second add

tool.pyright]
typeCheckingMode = "standard"
reportMissingImports = false # Ignore missing stubs in imported modules

third, remove mypy references

stan-dot commented 1 week ago

25 errors in src, 9 errors in tests

stan-dot commented 1 week ago

working on it

stan-dot commented 1 week ago

sim_motor types issues - might ignore but alternatively just delete

stan-dot commented 1 week ago

task worker state is also problematic

stan-dot commented 1 week ago

also run engine 'run' part with the hooks is unclear