DiamondLightSource / bluesky-stomp

STOMP messaging integration for bluesky
Apache License 2.0
1 stars 0 forks source link

MessagingTemplate disconnect method should be idempotent #22

Open abbiemery opened 10 months ago

abbiemery commented 10 months ago

The disconnect method for the messaging errors if called when it is already disconnected. Instead it should do nothing. To avoid this causing issues the stop method in service handler has had a if statement added to it to check if its connected before trying to disconnect it, but this should be able to be taken back out.

stan-dot commented 6 months ago

what are the steps to reproduce the issue? which disconnect method is this? image