search

DiamondLightSource / cothread

Cooperative Python Threads and EPICS Channel Access bindings
Apache License 2.0
13 stars 9 forks source link

Provide version information dynamically #50

Closed AlexanderWells-diamond closed 1 year ago

AlexanderWells-diamond commented 1 year ago

This is taken from the python3-pip-skeleton init file, which was lost during the initial adoption. This provides a version number even if cothread has never been installed

codecov[bot] commented 1 year ago

Codecov Report

Merging #50 (f27934e) into master (033f0b0) will decrease coverage by 0.32%. The diff coverage is 83.33%.

@@            Coverage Diff             @@
##           master      #50      +/-   ##
==========================================
- Coverage   59.76%   59.44%   -0.32%     
==========================================
  Files          15       15              
  Lines        2048     2059      +11     
==========================================
  Hits         1224     1224              
- Misses        824      835      +11
Files Coverage Δ
src/cothread/__init__.py 92.85% <83.33%> (-7.15%) :arrow_down:

... and 1 file with indirect coverage changes

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

AlexanderWells-diamond commented 1 year ago

This was decided to not be worthwhile - the number of people who may run into trouble for not having a generated _version.py file is extremely limited - it'd only affect people who wish to do import cothread without having done a pip install ... command.