DiamondLightSource / cs-web-lib

Library form of control system web UI prototype
Apache License 2.0
1 stars 1 forks source link

Alarm sensitivity is not handled correctly #51

Open rjwills28 opened 8 months ago

rjwills28 commented 8 months ago

Currently cs-web-lib uses the property border_alarm_sensitive to decide whether to show a widget in the alarm state. This is inconsistent with the CSS implementation where the widget always acknowledges the alarm state and the user can optionally decide to also show this as a border.

CSS implementation for border_alarm_sensitive. Note that if false it still displays the value as red indicating it is in alarm state. css_alarm

WebUI implementation. Note that when border_alarm_sensitive=false we get no alarm information webui_alarm

MJGaughran commented 8 months ago

What is the behaviour on Phoebus?

rjwills28 commented 8 months ago

Interesting - different to both: Phoebus phoebus_alarm