DiamondLightSource / cs-web-lib

Library form of control system web UI prototype
Apache License 2.0
1 stars 1 forks source link

Update to React 18 and MUI 6 #67

Closed dperl-dls closed 15 hours ago

dperl-dls commented 2 weeks ago

I'd like to start using this for some of our ongoing web GUI work (to hopefully take advantage of your upcoming PVWS integration), and not start off with out-of-date dependencies, so I took the liberty of upgrading them. It only required very minimal changes.

dperl-dls commented 1 week ago

Thanks for the review, I didn't notice those issues when building locally, perhaps I still had those settings in my local environment or something - I will look into them and try to add them to the CI too (seeing as that didn't break due to this issue...)

abigailalexander commented 1 week ago

That would be good, thanks. It seems like we only test the build in CI on tag push (when we publish to npm). It would be useful to have that as a check on a normal PR

dperl-dls commented 1 week ago

I think that the rollup build is fixed now, but I'm not sure how to test it properly - is there a way to run the unit tests against the built module or something?