search

DiamondLightSource / dls-python3-skeleton

Archived in favour of https://github.com/DiamondLightSource/python-copier-template
Apache License 2.0
1 stars 0 forks source link

early check for bad package name #11

Closed gilesknap closed 2 years ago

gilesknap commented 2 years ago

Check package name at start of 'new' command to avoid creating git repo before failing.

gilesknap commented 2 years ago

ooops - did not adhere to protocol

I guess I need to enable git hooks

codecov[bot] commented 2 years ago

Codecov Report

Merging #11 (876d367) into master (bf37f63) will increase coverage by 0.03%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #11      +/-   ##
==========================================
+ Coverage   99.08%   99.11%   +0.03%     
==========================================
  Files           2        2              
  Lines         109      113       +4     
==========================================
+ Hits          108      112       +4     
  Misses          1        1
Impacted Files Coverage Δ
src/dls_python3_skeleton/__main__.py 99.09% <100.00%> (+0.03%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update bf37f63...876d367. Read the comment docs.

gilesknap commented 2 years ago

Yes, that would be more robust. Sorry for delays, I'm not getting any notifications from github (and they are not going to junk either)