DiamondLightSource / dls-python3-skeleton

Archived in favour of https://github.com/DiamondLightSource/python-copier-template
Apache License 2.0
1 stars 0 forks source link

Docs don't say how to use linting #35

Open aawdls opened 2 years ago

aawdls commented 2 years ago

Docs say how to run the tests but not how to run the lint / static checks.

Docs don't explain how to set up pre-commit

Are these infos elsewhere? Otherwise I'd like to add them.

Also the linting is not run in the Gitlab CI template (since it was separated from pipenv run tests)

gilesknap commented 2 years ago

I think this page has those points? https://dls-controls.github.io/dls-python3-skeleton/master/reference/contributing.html

gilesknap commented 2 years ago

re gitlab we need to look at that...