DiamondLightSource / dodal

Ophyd devices and other utils that could be used across DLS beamlines
Apache License 2.0
2 stars 8 forks source link

IVU Compatible Insertion Device #389

Closed callumforrester closed 4 months ago

callumforrester commented 6 months ago

Follow-up to insertion device for I22 requirement in #377. I22 has an IVU insertion device, which is different to the CPMUs used by I03 and I04. Further consultation is needed to see if the PVs are sufficiently similar that the current Undulator device can be generalised (and ported to ophyd-async) or if it makes sense to create a new one.

@Tom-Willemsen I see you've done some work on I23, which has the same type as I22, did you ever look into making an ophyd device for the ID.

Acceptance Criteria

Tom-Willemsen commented 6 months ago

@Tom-Willemsen I see you've done some work on I23, which has the same type as I22, did you ever look into making an ophyd device for the ID.

No, I don't think I ever looked at this - the work on i23 that I did was for a very narrow use-case (OAV pin-tip detection), I don't think any other devices were added.

callumforrester commented 6 months ago

Have consulted with Controls, the I22 Undulator should behave similarly to the I03/I04 one from an EPICS perspective, so the existing ophyd device will hopefully work for both beamlines. In which case this ticket just becomes about porting it to ophyd-async.

DominicOram commented 6 months ago

We would presumably want to rename from Undulator -> InsertionDevice to be more generic?

DominicOram commented 6 months ago

Tested running the ophyd undulator against I22 and it works without changes, should be easy to convert