DiamondLightSource / fastcs-eiger

Prototype Eiger Control System Integration with FastCS
https://github.com/DiamondLightSource/FastCS
Apache License 2.0
1 stars 0 forks source link

Refactor initialize #30

Closed GDYendell closed 5 months ago

GDYendell commented 5 months ago

Separate initialize into logical steps:

This removes the limitation that key clashes are only handled between adjacent subsystems.

codecov[bot] commented 5 months ago

Codecov Report

Attention: Patch coverage is 32.05128% with 53 lines in your changes are missing coverage. Please review.

Project coverage is 43.29%. Comparing base (bb8e27e) to head (4bf7cba). Report is 7 commits behind head on main.

:exclamation: Current head 4bf7cba differs from pull request most recent head 9affc2b. Consider uploading reports for the commit 9affc2b to get more accurate results

Files Patch % Lines
src/eiger_fastcs/eiger_controller.py 34.84% 43 Missing :warning:
src/eiger_fastcs/http_connection.py 16.66% 10 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #30 +/- ## ========================================== + Coverage 39.03% 43.29% +4.25% ========================================== Files 4 4 Lines 228 261 +33 ========================================== + Hits 89 113 +24 - Misses 139 148 +9 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.