Closed PeterC-DLS closed 3 months ago
Thanks very much @PeterC-DLS for the code review!
I've created a branch and made the changes you've suggested. The pull request #2 is now available for you to check.
I've primarily used the inbuilt linter/ analysis in PyCharm for the project, but I've checked it against ruff and mypy as well.
Interestingly PyCharm's inbuilt type checking and the mypy plugin show now errors, but if you run mypy directly it still gives a load, although the are pretty insignificant so I've stuck to the built in ones.
Merged pull request #2, all issues addressed. Some additional comments addressed in #4
Some issues from a quick review of the code without examining its semantics or coding style
_class
or_functions
__all__
in__init__.py
to declare wildcard importsrequire.txt
is superfluous if you declare your dependencies in the project filetest_edge_cases
)Have you used ruff to check and format it? And mypy or pylance to analyse it?