DiamondLightSource / httomo

High-throughput tomography pipeline
https://diamondlightsource.github.io/httomo/
BSD 3-Clause "New" or "Revised" License
4 stars 3 forks source link

Replace angles length consistency check appropriately #236

Open yousefmoazzam opened 4 months ago

yousefmoazzam commented 4 months ago

This commit 608a0fd removed a consistency check in DataSetBlock which was asserting that the number of angles wasn't less than the number of projections. This turned out to not always be true (360 data which has been stitched together will have half the original number of angles, so the number of angles will be less than the number of projections in general for 360 pipelines).

However, it ma be sensible to have some kind of consistency check between the number of angles and the data, given that the angles held in AuxiliaryData is modifiable via a setter defined on DataSetBlock.

Alternatively, perhaps the angles numpy array could be locked/not writeable by default, to reduce the possibility of the number of angles going out of sync with the number of projections (by limiting the situations in which the angles array is modifiable).