search

DiamondLightSource / httomo

High-throughput tomography pipeline
https://diamondlightsource.github.io/httomo/
BSD 3-Clause "New" or "Revised" License
4 stars 3 forks source link

Move output dir path creation out of logger setup function #289

Closed yousefmoazzam closed 2 months ago

yousefmoazzam commented 2 months ago

It's not necessary to have the output directory be created by the logger setup function. It's best to have that function do logger setup and only logger setup: https://github.com/DiamondLightSource/httomo/blob/f4badc5558592176b4146d1c70934c4baead2e8d/httomo/logger.py#L6-L12

yousefmoazzam commented 2 months ago

The output dir creation is so short it can probably be done in cli.py somewhere around here: https://github.com/DiamondLightSource/httomo/blob/f4badc5558592176b4146d1c70934c4baead2e8d/httomo/cli.py#L68-L78

yousefmoazzam commented 2 months ago

Completed in merge of #294