Remove redundant loader check in UI layer - Githubissues

DiamondLightSource / httomo

High-throughput tomography pipeline

https://diamondlightsource.github.io/httomo/

BSD 3-Clause "New" or "Revised" License

4 stars 3 forks source link

Remove redundant loader check in UI layer #315

Open yousefmoazzam opened 1 month ago

yousefmoazzam commented 1 month ago

As per the TODO comment: https://github.com/DiamondLightSource/httomo/blob/ae5610a83a691436e0e7deff3a71c2af3f89568e/httomo/ui_layer.py#L114-L116

yousefmoazzam commented 1 month ago

Wait, it looks like such a check already exists in the YAML checker, this function: https://github.com/DiamondLightSource/httomo/blob/ae5610a83a691436e0e7deff3a71c2af3f89568e/httomo/yaml_checker.py#L79-L99

and it's executed in the main check function here: https://github.com/DiamondLightSource/httomo/blob/ae5610a83a691436e0e7deff3a71c2af3f89568e/httomo/yaml_checker.py#L385

So, maybe the check in the UI layer should just be removed, it looks to be redundant?