search

DiamondLightSource / httomo

High-throughput tomography pipeline
https://diamondlightsource.github.io/httomo/
BSD 3-Clause "New" or "Revised" License
4 stars 3 forks source link

Uncomment commented-out CLI tests? #321

Closed yousefmoazzam closed 1 month ago

yousefmoazzam commented 1 month ago

There are several commented-out CLI tests: https://github.com/DiamondLightSource/httomo/blob/833936aaa1049feac5c55a2195e99454dee85fcc/tests/test_cli.py#L26-L67

  1. test_cli_noargs_raises_error is asserting that the CLI raises an error if no args at all are passed
  2. test_cli_check_pass_data_file is asserting that the YAML checker produces output saying it's checking paths in the input data if it's given a data file
  3. test_cli_pass_output_folder is asserting that the user.log file is found in the custom output dir specified (this flags is reintroduced in #306)

I'm not sure why 1 was commented out?

With the YAML checker stuff merged in #201, it seems like the YAML check test in 2 should be uncommented.

When #306 is merged, I think 3 should be uncommented.

yousefmoazzam commented 1 month ago

Completed in merge of #332